Vocabulary dictionary

Kanji dictionary

Grammar dictionary

Sentence lookup

test
 

Forums - Issue with word's explanation pop up in example sentences (on {android}mobile).

Top > renshuu.org > Bugs / Problems



avatar
sand_eto
Level: 199
2198d4afdf1581f1b10f8b74.jpg

Note from マイコー/Michael: due to a potentially severe illness, it is quite possible that I will not be able to respond to bug reports in a timely manner. However, I do encourage you to post here, as there are many wonderful members of our community who should be able to help.

2
8 months ago
avatar

I have also seen this on the iPhone, so it’s not an android exclusive issue. A workaround is to scroll or otherwise manipulate the window so that the pop up appears below the word instead of above it.

1
8 months ago
avatar
マイコー
Level: 326

yea, it makes sense that it is not tied to a specific device type.

If either of you can get to this from a consistent set of steps (which would ideally mean from OUTSIDE of a quiz, such as a sentence lookup, word list, etc.), then definitely let me know!

1
8 months ago
avatar
sand_eto
Level: 199

Thank you Michael for taking the time to look into this!

The thing is I cannot reproduce this bug outside the quizz mode. I.e. checking example sentences for a word in the dictionary does not (re)produce this behaviour. It only happens in quizz mode & what's more only for some words even within the very same example sentence. And trying to scroll up and down to hopefully make the pop up appear somewhere else does not work for me: the pop-up location do not change & produce the very same outcome.

0
7 months ago
avatar
マイコー
Level: 326

Thanks for the followup. If it is a word that is the same word that is being quizzed, then perhaps making a schedule or list of just that word so we can get a quick loop built will help us knock out the issue

0
7 months ago
avatar

It seems to me that I’ve been able to produce it outside of a quiz by doing a sentence search. I think all it requires is a word with a multi-line definition in a short sentence that fits on one line at the top of the page. But I can’t reproduce it now. It cropped up randomly and it may have gone away in the same fashion.

0
7 months ago
avatar
マイコー
Level: 326

Just copying in a bit of info from another user who has been sending me info via DM. Like everything else, it has not yet been something I can replicate, but they seemed to note that it would most often happen when the sentence spanned 3 or more lines.

0
7 months ago
avatar

Long sentences could be a part of it too. I was mostly focusing on short sentences because as far as I can tell the bug only triggers for words on the first line.

0
7 months ago
avatar

I have another example from a quiz. Unfortunately, I can’t duplicate it outside of the quiz.

1084e61e527b1ce28bd0af6b.jpg


0
6 months ago
avatar
マイコー
Level: 326

If anyone sees it on desktop and are comfortable with the web inspector, I'd love to see the CSS styles applied to the modal. It's id ttip

0
6 months ago
avatar

Kinda hard to replicate for me. Is this good enough? I have to mess with the Zoom quite a bit to get this. Not exactly the same though.

03206c760f3dbf90f666e4df.png

line-height: 1.3;
-webkit-tap-highlight-color: rgba(0,0,0,0);
-webkit-text-size-adjust: none;
-webkit-font-smoothing: antialiased;
font-family: "UDDigiKyokasho M JIS2004", 'Open Sans' !important;
word-spacing: 0;
display: flex;
-webkit-box-direction: normal;
-webkit-box-orient: horizontal;
flex-direction: column;
text-align: left;
z-index: 600;
overflow-y: auto;
box-sizing: border-box;
color: var(--text);
padding: 10px 10px 12px;
background-color: var(--bg_main);
border-radius: 6px;
box-shadow: 0 0 30px rgba(255,255,255,.3);
font-size: inherit;
position: absolute;
max-height: 2.787px;
left: 75px;
max-width: 300px;
visibility: visible;
width: 310px;
top: 346.213px;


It also occurs at a specific scroll position and zoom:

b2dca868cd2595e93332f203.png

At 100% zoom when I force it to flip to the bottom, this happens. If I zoom in (110%), it fixes itself.


I can't replicate the behaviour from the dictionary (same sentence).


Edit: It's some viewport calculation problem where the max-height gets set to 13px (like what you see in the image), if I set it to 200-400px it fixes itself. Had a similar problem a while back in the dictionary, that got fixed.

Hopefully what I posted makes sense, it's 3:30 a.m.


Edit: It seems to calculate the top (CSS) before max-height is set, so you end up with it detaching further upwards based on the height hidden by the scroll. If I fix it manually, the top would match the max-height of ttip, if it wasn't scrollable.


Works fine at 100%, breaks at 125%, keeps pushing farther away (up), fixes at 250%


Seems to be a problem when ttip becomes scrollable. Here's what I mean:

ca18979fc9b3993d568243b6.png
0
6 months ago
avatar
マイコー
Level: 326

Yep, definitely looks like the max-height. The tooltip/popup code is VERY code (with a ton of changes over the years) so I think you are on the right path - it is trying to prevent larger tooltips from going below the bottom of the visible page, but something is causing it either to a)not get recalculated, or b)is using an invalid calculation to generate the height.

It'll be quite tricky unless we can get a reproducible case outside of the quizzes so we do not need to rely on the specifics of what the quiz is showing.

0
6 months ago
avatar

A quick update: You can consistently reproduce it on pretty much any (tested a few dozen) "result" screen for a term (word). Even before you expand "See more sentences". When I zoom in to the point the container (marked in red) no longer fits the screen space/viewport, the tooltips (for the sentence) start breaking.

8bb7488564333ac1c40305d5.png

When I expand "See more sentences", and keep my zoom where I normally have it (100%), tooltips seem to start breaking somewhere in the range marked with blue. Generally near the middle or closer to the top of the container marked in red. When I zoom out to where it's in full view, everything seems to work fine. If I zoom in a lot (250-300%) something in the logic flips and things start working fine.

432cf50c918909c54865cf29.png
  • fully visible container → fine
  • partially visible container → broken
  • absurd zoom → fine again


Update: You can reproduce it in Lists too. This is from "JLPT N3 (Intermediate) Grammar examples > Pack #1 (1-100)"

59659ce65170b57ab767a5d8.png

From what I've tested it seem to happen for sentences close to the top of the list (3rd and/or 4th sentence). Maybe that helps.


As I zoom out, the sentences that break start shifting down. So if at 100% zoom the 4th sentence (from the top) breaks, at 50%, it's the 7th sentence that breaks.

1
6 months ago
avatar
マイコー
Level: 326

Amazing detective work! I believe I've made some progress with this - let me know if you see an improvement on your end.

1
6 months ago
avatar

Difficult to say. Feels like something's changed, but it's been a week and I didn't write down the exact positions and settings. The main issue with the calculation seems to still be present.

d7217fb4a7dad068f99f1641.png784793ae1e13e584caf7f910.png

For the above example, the 3rd sentence (same pack from the N3 sentences) seems to break quite a bit, while the 4th breaks less (maybe). It's now just りたがっている that breaks in that sentences. I feel like more words broke before.

Not much more I can do. I can probably help more if you DM me the code snippet that handles the calculation. I can see it's the reitip2 function and where it's being called from, but I can't access it.

Anyway, good luck and let me know if you need me to test anything :)


PS: If someone else can test to see if they feel a difference that would help.

0
6 months ago
avatar
マイコー
Level: 326

Thanks again. It should have auto-downloaded the new js assets, but just to be safe, please clear out the cache on your browser for the domain and make sure it got the new files. Prior to making the changes, I *was* able to replicate the issue, and have not been able to since then.


0
6 months ago
avatar
マイコー
Level: 326

Scratch that last message, I've got something.

0
6 months ago
avatar
マイコー
Level: 326

I think I may be rolling back some other fix, but for now, I disabled a slice of code that seemed to be causing more problems than fixing ones.

2
6 months ago
avatar

Got it. I cleared out the cache a few minutes ago and didn't see a difference. Should I clear it out again? As in, do you need me to check anything?


Edit: Seems to work now. Tested it a bit more and it looks good :)


Did you roll back the fix for this problem? I'm pretty sure that got fixed a while back. The scroll not appearing when you expand "Show alternate grammar" that is. Fixing one thing while breaking something else is unfortunately quite common :D

505ce265719504f408c9f776.png
1
6 months ago
avatar
sand_eto
Level: 199

Just a confirmation that the problem seems indeed to have disappeared & been consequently fixed. Thank you to everyone involved in the detective & solving work!👍🙂

1
6 months ago
Getting the posts




Top > renshuu.org > Bugs / Problems


Loading the list
Lv.

Sorry, there was an error on renshuu! If it's OK, please describe what you were doing. This will help us fix the issue.

Characters to show:





Use your mouse or finger to write characters in the box.
■ Katakana ■ Hiragana